oyarzun commented on pull request #2563: URL: https://github.com/apache/netbeans/pull/2563#issuecomment-752642553
@mcdonnell-john thanks for taking a look at the PR. The application name in the Security & Privacy panel, is coming from `CFBundleName` in the Info.plist. It gets populated with [nbbuild/installer/newbuild/netBeants/nbide/build.xml](https://github.com/apache/netbeans/blob/master/nbbuild/installer/mac/newbuild/netBeans/nbide/build.xml) and [nbbuild/installer/mac/newbuild/build.pro](https://github.com/apache/netbeans/blob/0415bfa6e3abd4ae8881d966c279e2156b2763d5/nbbuild/installer/mac/newbuild/build.pro#L32) from the [NB_VER_NUMBER](https://github.com/apache/netbeans-jenkins-lib/blob/ff762b4a31c244a1ae05db7d2ace8a93c5e611e3/resources/org/apache/netbeans/installermac.sh#L130). So I imagine you had `NB_VER_NUMBER=X.XX` when you built the installer? I was not familiar with apache/netbeans-jenkins-lib, I thought the mac installers were built manually. The other option could be to have the native Mac launcher already prebuilt, like the Windows launcher. But I was not sure how submit a PR that has a new external binary. This launcher is only for the NetBeans app bundle [ide.launcher](https://github.com/apache/netbeans/tree/master/nb/ide.launcher), not RCP app bundles [api.harness](https://github.com/apache/netbeans/tree/master/harness/apisupport.harness). I was planning on submitting another PR to address the RCP launcher. I believe it will need to be a prebuilt external binary like Window. This would allow the mac RCP installer to be build on any platform since it does not use Apple's `pkgbuild`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
