KacerCZ commented on pull request #2674:
URL: https://github.com/apache/netbeans/pull/2674#issuecomment-759772580
I tested your changes as described in first post and it works without any
problems.
I also went through RFC and tried unsupported usages.
* Usage of `var` modifier is not allowed - syntax error is shown - OK.
Following usages were not recognized as errors. None of them is deal-breaker.
* None if wrong modifier usage is not recognized as error. Sample code from
RFC:
```php
// Error: Not a constructor.
function test(private $x) {}
abstract class Test {
// Error: Abstract constructor.
abstract public function __construct(private $x);
}
interface Test {
// Error: Abstract constructor.
public function __construct(private $x);
}
```
* Promoted property can not have type `callable` - no error is shown and
code completion offers `callable` after visibility.
```php
class Test {
public function __construct(public callable $callback) {}
}
```
Promoted property can't be variadric - no error is shown.
``` php
class Test {
public function __construct(public string ...$strings) {}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
