oyarzun commented on pull request #2563: URL: https://github.com/apache/netbeans/pull/2563#issuecomment-765609408
@mcdonnell-john > Though there appears to be new a commits since that point in time. If this commit @oyarzun was reverted and moved into its own PR I'd be comfortable merging this PR without that additional commit as I've tested it to that point. > I'd say this is needed to merged otherwise we'll get more issues because of BigSur, but not comfortable merging it with that additional commit at this late stage. NETBEANS-5004 is not specific to Big Sur, it is also an issue on Catalina. The code in that commit is not compiled or used until we solve the binary upload to https://netbeans.osuosl.org/binaries/. At which point it will be included in the harness. Currently with the PR as is, there is no chance that commit will break anything. But if you want me to revert it, I will and submit a separate PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
