JaroslavTulach commented on pull request #2693:
URL: https://github.com/apache/netbeans/pull/2693#issuecomment-765867932


   The information on release version behavior is in [module system 
documentation](https://bits.netbeans.org/12.0/javadoc/org-openide-modules/org/openide/modules/doc-files/api.html)
 (which isn't easy to find) and also in Javadoc of 
[ModuleInfo](https://bits.netbeans.org/12.0/javadoc/org-openide-modules/org/openide/modules/ModuleInfo.html#getCodeNameRelease--)
 which mentiones that if the release version isn't defined, it defaults to 
`-1`...
   
   > See for reference 
https://github.com/apache/netbeans/blob/master/platform/libs.jna/manifest.mf#L3 
although I think /1 is right here?
   
   As such changing to `/1` properly changes the release version from `/-1` to 
new value.
   
   > Also, this _is_ the flat guys! 
   
   I see. Consider setting 
[sigtest](https://github.com/jtulach/netbeans-apitest) up.
   
   > And it's not that unusual for incompatible changes on major version 
changes - 
   > something normally handled by not exposing third-party APIs in the past?
   
   `platform/libs.flatlaf/nbproject/project.xml` declares public packages 
because `platform/o.n.swing.laf.flatlaf/nbproject/project.xml` depends on it. 
As NetBeans project tries to prevent usage of friend packages, the API is 
exposed to anyone. That is good for reuse, but also a problem with 3rd party 
dependencies that don't stick to backward compatibility that much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to