matthiasblaesing edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774231385


   > @JaroslavTulach @eppleton looks like nb-javac-15.0.0.1-impl.jar is not 
present at 
https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar. 
If the file nb-javac-15.0.0.1.jar is impl jar please change the name of jar to 
add -impl at the end.
   
   @Akshay-Gupta-Oracle this won't work. Sonatype requires for artifacts 
distributed via OSSRH to contain at least one primary artifact, which has to be 
named with a type suffix. 
   
   The modifications to the nbjavac build create two jars:
   - `nb-javac-15.0.0.1.jar` is the old "-impl"
   - `nb-javac-15.0.0.1-api.jar` is and was the "-api" package
   
   It was done this way, so that the two artifacts can be published together.
   
   I had a look at this PR yesterday and here you can see how I tackled it 
(feel free to pull if you agree):
   
   
https://github.com/matthiasblaesing/netbeans/commit/277e1583ae29fa493a15ccb894da5ae1415833ea
   
   Changes in the referenced commit:
   
   - moved dependencies to maven central download
   - updated `nbbuild/templates/projectized.xml` to reference the correct 
artifact
   - fixed naming of 
`nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15.0.0.1-api.jar.external`
 and ` 
nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external`
 (this is an independent problem from the maven central move, just a bugfix for 
the original PR) and moved to the maven central dependency
   - fixed for `binary-origin` in `java/libs.javacimpl/nbproject/project.xml ` 
(this is an independent problem from the maven central move, just a bugfix for 
the original PR)
   
   PS: @eppleton thank you for the quick upload!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to