ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r598338563



##########
File path: 
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
     }
 
     protected String getUnquotedIdentifier() {
+        if (quoter == null)
+            return "";

Review comment:
       Silly question, how should that "Quoter" be created? 
   
   I see a case like the below using SQLIdentifer to created it, but in this 
case since there is no conn available, using the meta data I don't believe 
would be possible. 
   
   DatabaseMetaData dmd = conn.getMetaData();
   quoter = SQLIdentifiers.createQuoter(dmd)
   
   I also see 
   NonASCIIQuoter(String quoteString)
   
   So would quoter = new NonASCIIQuoter(""); be what you're suggesting or 
something else?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to