sdedic commented on a change in pull request #3004:
URL: https://github.com/apache/netbeans/pull/3004#discussion_r655389029
##########
File path:
extide/gradle/src/org/netbeans/modules/gradle/actions/DefaultActionMapping.java
##########
@@ -145,5 +145,10 @@ public boolean equals(Object obj) {
}
return Objects.equals(this.withPlugins, other.withPlugins);
}
+
+ public static DefaultActionMapping DISABLED = new DefaultActionMapping();
Review comment:
Hm, originally I had it there - but then it's not that easy, since if
the `ActionMapping` is to be returned from some Provider, it should probably
hold that `ActionMapping.getName().equals(the_id_passed_to_the_provider)`. A
generic DISABLED with no `name` property at all should remain just an internal
placeholder.
If something should be public, then a factory method `disabledAction(String
name)` to have a correct instance floating around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
