sdedic opened a new pull request #3011: URL: https://github.com/apache/netbeans/pull/3011
Two fixes. 1. If the project is not known, thanks to @JaroslavTulach null check the call proceeds through a series of async calls to finally return an empty array; this change does the same in a short path. I think that with no project, the original code does not wait on any Future from the backlog of projects being opened, so the change should have no impact on the sequence of operations. 2. The commit a2446ef introduced `HintsInvoker` invocation during execution of `codeAction` LSP request; although the request can return an unfinished `CompletableFuture`, which allows the client to issue additional requests through LSP protocol, the impl fully computed the code actions, then returned a `completedFuture`. The change only forks the heavy computation to background, and completes the future at the end of the task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
