sdedic commented on a change in pull request #3037:
URL: https://github.com/apache/netbeans/pull/3037#discussion_r663333114
##########
File path:
groovy/groovy.support/src/org/netbeans/modules/groovy/support/actions/GroovyComputeTestMethods.java
##########
@@ -53,19 +54,24 @@
int classStartColumn = classNode.getColumnNumber();
int classOffset = classStartLine > 0 && classStartColumn > 0 ?
getOffset(text, classStartLine, classStartColumn) : 0;
for (MethodNode methodNode : classNode.getMethods()) {
- int startLine = methodNode.getLineNumber();
- int startColumn = methodNode.getColumnNumber();
- int endLine = methodNode.getLastLineNumber();
- int endColumn = methodNode.getLastColumnNumber();
- if (startLine > 0 && startColumn > 0 && endLine > 0 &&
endColumn > 0) {
- int startOffset = getOffset(text, startLine,
startColumn);
- int endOffset = getOffset(text, endLine, endColumn);
- result.add(new
TestMethodController.TestMethod(classNode.getName(),
- new SimplePosition(classOffset),
- new
SingleMethod(parserResult.getSnapshot().getSource().getFileObject(),
methodNode.getName()),
- new SimplePosition(startOffset),
- new SimplePosition(startOffset),
- new SimplePosition(endOffset)));
+ for (AnnotationNode annotation :
methodNode.getAnnotations()) {
+ if
("org.spockframework.runtime.model.FeatureMetadata".equals(annotation.getClassNode().getName()))
{
Review comment:
Q: does this mean that previously some methods (without FeatureMetadata
annotation) could be to the test results although they weren't eligible
actually ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
