JaroslavTulach commented on a change in pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123#discussion_r695722532
##########
File path:
ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
Is this new API class supposed to be subclassable? As it seems it is...
##########
File path:
ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
There should be an API change note, I assume. Btw. is everything
referenced - e.g. `SimpleRefactoringElementImplementation`,
`RefactoringElementsBag` already public? Btw. I don't see a reason why this
class was made public - searching for `MoveFile` yields no results...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
