neilcsmith-net commented on pull request #3136:
URL: https://github.com/apache/netbeans/pull/3136#issuecomment-907612524
In theory was the call to `notifyAll()` at line 107 assumed to cover all
bases? While this is probably a good change, is not the call to `setLookups()`
a problem here as well as it's effectively holding a lock and firing listeners?
Should they both be passing an executor, possibly a single one, to fire
listeners async?
eg. one of the stack traces has this -
```
at java.lang.Object.wait([email protected]/Object.java:328)
at
org.netbeans.modules.projectapi.LazyLookupProviders$1Prov$1.beforeLookup(LazyLookupProviders.java:84)
- waiting to re-lock in wait() <0x0000000099880000> (a
[Ljava.lang.Thread;)
at
org.openide.util.lookup.ProxyLookup.beforeLookup(ProxyLookup.java:268)
....
at
org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:184)
at
org.netbeans.spi.project.support.DelegatingLookupImpl.doDelegate(DelegatingLookupImpl.java:168)
- locked <0x0000000099880458> (a java.util.ArrayList)
at
org.netbeans.spi.project.support.DelegatingLookupImpl.resultChanged(DelegatingLookupImpl.java:84)
at
org.openide.util.lookup.ProxyLookup$1Notify.run(ProxyLookup.java:239)
at
org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:248)
at
org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:184)
at
org.netbeans.modules.projectapi.LazyLookupProviders$1Prov$1.beforeLookup(LazyLookupProviders.java:97)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
