lkishalmi commented on a change in pull request #3135:
URL: https://github.com/apache/netbeans/pull/3135#discussion_r699457049
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/ActionProviderImpl.java
##########
@@ -500,14 +503,12 @@ Action forProject(Project p, FileObject fo) {
private final class CustomPopupActions extends AbstractAction implements
Presenter.Popup {
private final boolean onFile;
- private final boolean onGradle;
private final Lookup lookup;
@SuppressWarnings("OverridableMethodCallInConstructor")
private CustomPopupActions(boolean onFile, boolean onGradleFile,
FileObject fo) {
Review comment:
Well it is not used, but calculated earlier. This one is a copy+paste
left over from the maven plugin. Probably have to check why we calculate that
on the first place, also check that in the "original" maven plugin code as well.
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/nodes/TaskNode.java
##########
@@ -45,6 +46,8 @@
@StaticResource
private static final String TASK_ICON =
"org/netbeans/modules/gradle/resources/gradle-task.gif";
+ public static final String EXECUTE_TASK_ACTION = "execute.task"; //NOI18N
Review comment:
Good catch! I've put the constant in different places initially all
around the source code. RunUtils might be not the final place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
