entlicher commented on pull request #3150:
URL: https://github.com/apache/netbeans/pull/3150#issuecomment-912394216
When examining the properties that can be associated with breakpoints via
DAP, I've found some issues:
- logging breakpoints should not break the execution according to the spec.
- log message can contain {<expression>} to log expression values
- Truffle breakpoints (for guest languages) did not have an ability to log
messages
The above issues are resolved by this PR:
- The LSP's `NbBreakpoint` instructs breakpoints not to suspend when there's
a log message. It also translates patterns of `{...}` to `{=...}` which assure
that JPDA (and now also Truffle) breakpoints evaluate the expressions.
- `TruffleLineBreakpoint` has new suspend and printText properties.
- There is a new `TruffleBreakpointsRegistry`, which associates
`TruffleLineBreakpoint` (`JSLineBreakpoint` in general, which can be set in JS
files) with `com.oracle.truffle.api.debug.Breakpoint` in the debuggee
(represented by `ObjectReference`).
- When Truffle breakpoint is hit, we create the new `HitBreakpointInfo` and
use the new `TruffleBreakpointOutput` to print out log message or condition
exception for Truffle breakpoints.
- There's also a small change in JPDA's `DebuggerOutput` that assures that
names of guest languages sources are printed out instead of the
infrastructure's `JPDATruffleAccessor` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
