JaroslavTulach commented on a change in pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367#discussion_r768368737
##########
File path: java/j2ee.persistence/nbproject/project.xml
##########
@@ -52,6 +52,15 @@
<specification-version>1.0</specification-version>
</run-dependency>
</dependency>
+ <dependency>
+ <code-name-base>org.netbeans.api.lsp</code-name-base>
Review comment:
Adding such lightweight dependency is OK.
##########
File path: java/java.lsp.server/nbcode/nbproject/platform.properties
##########
@@ -325,12 +311,10 @@ disabled.modules=\
org.netbeans.modules.xml.catalog.ui,\
org.netbeans.modules.xml.jaxb,\
org.netbeans.modules.xml.jaxb.api,\
- org.netbeans.modules.xml.multiview,\
Review comment:
A bit too many new dependencies. Could some of them be eliminated by
restructuring the modules? I am sure you don't really need `xml.multiview` in
VSCode. Why do we need `schema2beans`? `eclipselink`?
I understand that currently the needed modules (`*.persistance`?) have such
dependencies. What it would take to eliminate some of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
