sdedic opened a new pull request #3376: URL: https://github.com/apache/netbeans/pull/3376
This PR fixes two bugs. First - call me an idiot, but I used just syntax-sugar conversion instead of `Number(x)` to convert item IDs (which are numeric) to numbers. I did not notice it during var inspection in the debugger (just '9' vs 9) ... therefore items were not matched and updated properly, the items were never found in the `treeData` Map. Second is a race condition: sometimes, especially with lazy-initialized Nodes in NBLS, a query for Children started to initialize the Children, and so a certain `nodes/nodeChanged` could be received **before** the vscode even received the first `nodes/info` response for the node; the node change was then simply ignored. That results in dangling nodes, nodes like 'Please wait...' which are in the tree indefinitely etc. The fix is to track those pending changes, and delay `Promise<TreeItem>` completion after a new `nodes/info` response arrives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
