junichi11 commented on pull request #3444: URL: https://github.com/apache/netbeans/pull/3444#issuecomment-1011195803
@neilcsmith-net > do you have any idea why the FoldingTest fails here? It may be due to Ubuntu 20.04? Ant version? It fails locally for me with JDK 8 too. Perhaps, it is related to the following line, I suppose... https://github.com/apache/netbeans/blob/ae6389a98e30c459435800920a57363351dfd543/php/php.editor/src/org/netbeans/modules/php/editor/csl/FoldingScanner.java#L134 We expect that `FOLD_PHPTAG` is `true` by default. https://github.com/apache/netbeans/blob/ae6389a98e30c459435800920a57363351dfd543/php/php.editor/src/org/netbeans/modules/php/editor/csl/FoldingScanner.java#L174-L176 I'm using Ubuntu 20.04 Product Version: Apache NetBeans IDE 12.0 Java: 1.8.0_202; Java HotSpot(TM) 64-Bit Server VM 25.202-b08 Runtime: Java(TM) SE Runtime Environment 1.8.0_202-b08 System: Linux version 5.11.0-46-generic running on amd64; UTF-8; The test passed in my PC. > Also, is there anything in PHP editor we could run daily and/or if PR touches particular paths? Other than unit tests? Umm, I'm not sure... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
