matthiasblaesing commented on pull request #3465: URL: https://github.com/apache/netbeans/pull/3465#issuecomment-1018853717
I want to be truthful, I only looked at it and it looks sane to me (without going to deep into the inner workings of the debugger). From my perspective the first two commits look like good candidates for squashing, as they both just move files around. From a testing perspective, commits, that lead to a broken state (in this case b3290b2 and beefa36) should be avoided, as they give headaches if you try to bisect. Do we really loose something if all three commits are squashed? The IP is still clear: - the original code import was already voted on (@jlahoda took care of that) - all following changes went through normal committer stages and thus are also save As a final comment: The base of binary dependency `cpplite-mi` (source is here: https://github.com/matthiasblaesing/cpplite-mi) can be found in `contrib/cnd.debugger.gdb2` and `contrib/cnd.debugger.common2`. At a later stage (maybe even after integration of CND), we should drop the binary dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
