mbien commented on issue #3511:
URL: https://github.com/apache/netbeans/issues/3511#issuecomment-1024666762
I looked at this a little bit. I agree that `isNotFinalExceptionType` and
`isNotFinalClass` methods should not use `Class.forName` since it doesn't know
anything about the project.
To properly implement this we would have to call
`typeHandle.resolve(compilationInfo)` then get a type mirror to get the
modifiers. Getting a CompilationInfo is a bit of a ceremony unfortunately.
However, if we say that the filters only need to function on a best effort
basis, we could simply return true.
```
} catch (ClassNotFoundException ex) {
return true; // we don't know
}
```
this would show classes from project classpath even if they are final,
instead of showing nothing. Maybe its still good enough for the wizzard - I
don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
