JaroslavTulach commented on a change in pull request #3744: URL: https://github.com/apache/netbeans/pull/3744#discussion_r825690072
########## File path: nbbuild/travis/ant.sh ########## @@ -0,0 +1,60 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +function install() { + mkdir -p nbbuild/ + cd nbbuild/ + rm -rf travisbuildjdk* + wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh + chmod a+x install-jdk.sh + ./install-jdk.sh --feature 11 --license GPL --target travisbuildjdk +} + +function download() { Review comment: There was a discussion whether using `install-jdk.sh` is better than manual download from a fixed URL. I changed the code to use `install-jdk.sh`, but I still prefer the _fixed URL approach_ a bit more: - `install-jdk.sh` script may (and should, that's the whole point) change over time - e.g. the download may not always be the same - fixed URL (plus checksum) is really _fixed_. If you trust the URL provider (I trust Azul to keep it unchanged)... - anyway for purposes of running CI before integration the difference isn't huge either way As such I have switched to `install-jdk.sh` but left the original `download` function in the code, not called right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
