vieiro commented on PR #4057: URL: https://github.com/apache/netbeans/pull/4057#issuecomment-1114600880
Thanks for the throrough review, @matthiasblaesing! You're right that `getBindings` may indeed block, so we need to schedule these calls to `getBindings` in a common worker, but keep on using LSPBindings server-specific RequestProcessor (the `bindings.worker`). This `getBindings` looks like a good candidate to return a CompletableFuture, I think. Let me give a second though during the next days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
