sdedic opened a new pull request, #4072: URL: https://github.com/apache/netbeans/pull/4072
Yet another fixes to fix `java.mx.project` testsuite on JDK11. Potentially other testsuites, too - tests that access JPDA API should be now failing on JDK11, as `--limit-modules` does not allow them to see JPDA classes. This should be less controversial :) as we definitely want to access debugger support in platform from java cluster at least. - `java.mx.project` testsuite needs `mx` binary on PATH (or know full path to it); the buildscript `git clone`s one, but it's not on path. Moreover the copy made into `build/test/unit/data` directory omits executable attribute, so the git clone sources must be used directly Note that passing the `mx` location in system properties should also fix tests on JDK8 -- see for example [Test Java modules with nb-javac on Java 8](https://api.travis-ci.com/v3/job/568921174/log.txt): ``` [junit] java.io.IOException: error=2, No such file or directory [junit] at java.lang.UNIXProcess.forkAndExec(Native Method) [junit] at java.lang.UNIXProcess.<init>(UNIXProcess.java:247) [junit] at java.lang.ProcessImpl.start(ProcessImpl.java:134) [junit] at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029) [junit] Caused: java.io.IOException: Cannot run program "mx" (in directory "/home/travis/build/apache/netbeans/java/java.mx.project/build/test/unit/data/graal/sdk"): error=2, No such file or directory [junit] at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048) [junit] at org.netbeans.modules.extexecution.base.ExternalProcessBuilder.call(ExternalProcessBuilder.java:272) [junit] at org.netbeans.api.extexecution.base.ProcessBuilder$LocalProcessBuilder.createProcess(ProcessBuilder.java:301) [junit] at org.netbeans.api.extexecution.base.ProcessBuilder.call(ProcessBuilder.java:252) [junit] at org.netbeans.api.extexecution.base.ProcessBuilder.call(ProcessBuilder.java:71) ``` (but the test still completes successfully; strage ... will fix in a subsequent PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
