dbalek commented on code in PR #4128: URL: https://github.com/apache/netbeans/pull/4128#discussion_r877792346
########## groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/lexer/LexUtilities.java: ########## @@ -446,6 +511,15 @@ public static boolean isBeginToken(TokenId id, BaseDocument doc, int offset) { return END_PAIRS.contains(id); } + /** + * Return true iff the given token is a token that should be matched Review Comment: 'iff' usually means 'if and only if'. ########## java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java: ########## @@ -2243,4 +2285,220 @@ protected CallHierarchyOutgoingCall createResultItem(CallHierarchyItem item, Lis }; return t.processRequest(); } + Review Comment: Agree :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists