jgneff commented on PR #4206: URL: https://github.com/apache/netbeans/pull/4206#issuecomment-1149285133
@mbien Thank you, Michael, for the link to the old history. I was wondering how to go back even further. > However I have to wonder: wouldn't the safer fix be to simply ignore errors unless all tasks fail? I would like the number and type of connections to be deterministic. As it is now, it's almost random. You can define proxy environment variables but end up using mostly direct connections. It's a race, but instead of the first one winning, the last one to get to the instruction `conn[0] = test` before being terminated wins! > If we end up deciding to change this to an sequential approach, I believe we should use one task which does all sequentially. Having a countdown latch, thee tasks on one thread is probably not necessary. I decided on the most conservative change for now. I kept the same structure as the current code, but just made the tasks sequential. Eventually, I would like to rethink the entire approach. For example, the values of the proxy variables are not going to change during the build, so the code should get them just once from the environment instead of 565 times. Furthermore, I think the build should fail when the `http_proxy` doesn't work, for example, instead of moving on to try the value of `https_proxy` and then even a direct connection. I thought we could follow-up with a bigger design change once we have some experience with this small change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
