mbien commented on code in PR #4205:
URL: https://github.com/apache/netbeans/pull/4205#discussion_r893645710
##########
java/java.disco/src/org/netbeans/modules/java/disco/AdvancedPanel.java:
##########
@@ -88,7 +88,9 @@ protected void updateDistributions(List<Distribution>
distros) {
protected void setVersions(List<Integer> versions, Map<Integer,
TermOfSupport> lts) {
List<Integer> reversedVersions = new ArrayList<>(versions);
reversedVersions.sort(Collections.reverseOrder());
- ((VersionListCellRenderer) versionComboBox.getRenderer()).setLTS(lts);
+ VersionListCellRenderer renderer = (VersionListCellRenderer)
versionComboBox.getRenderer();
+ renderer.setLTS(lts);
+ renderer.setEA(reversedVersions.get(0));
Review Comment:
yep. the fist item should be always EA. Before the change it showed "19" in
the combo box but the table was always empty, Post change it will show "19
(EA)" and the table should contain items since the filter (Client.java) got
updated in
https://github.com/apache/netbeans/pull/4205/commits/3fed2681ee8f38dd5fe8e7322f97e21ae68d294e
too.
`ReleaseStatus.NONE` does not return EA builds for some reason, it appears
to be mapped to GA by default.
A similar issue happened with the "last" check box. The NONE filter did not
work as expected (it still filters), so I changed it in
https://github.com/apache/netbeans/pull/4205/commits/b9bdd54a0016a4407303b1732cd4934c68ad68fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
