mbien commented on PR #4205: URL: https://github.com/apache/netbeans/pull/4205#issuecomment-1162068531
> > I swear the quick select panel didn't have 19 on it yesterday. For some reason the API returns it as maintained now :( > > I've noticed similar in the past (and reported upstream) - likely something incorrectly parsed again. Defensive checks sound good! > > Changes look good - sorry only just getting around to properly trying out. I guess I'm not putting in a PR to remove the slider or table now then! smile I actually chatted with han solo himself via foojay slack and we found some bugs in the current data. For example some STS releases were reported as MTS (19 EA for example, you see it in the screenshot, han said it should be fixed now). There might be also a new method soon `disco.getAllMajorVersions` taking a distribution as input parameter - which would make it significantly more useful than now since the result currently only applies to zulu. Thats also when i started to add defensive checks. For example to figure out what is EA, the code does not query if the package is EA, it simply checks if version > latest version. It also only uses LTS now, everything else is assumed to be STS without even asking. The advanced panel will still show the actual value, but this is not used for quick select - it only shows LTS and latest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
