neilcsmith-net commented on PR #3115: URL: https://github.com/apache/netbeans/pull/3115#issuecomment-1166492331
> The dark gray background is a bit ugly, though. And how does this scheme work in the sidebar to the left, which is usually inactive? Agreed. It might be too much. But either we need background colour contrast or possibly make a border (like in your changes) across the whole tab top, in the accent colour when focused. Compare with eg. Thunderbird and Aqua LAF screenshots you shared earlier. I tried two different greys, depending on focus, so inactive are slightly darker - all ViewTab settings set to same named EditorTab setting. Maybe focus remains slightly accent coloured as it is now. I'll try a tweak tomorrow and share. > There are a few less controversial changes in this PR as well, such as .. adjusting the vertical height Personally, using a QHD desktop and sometimes a small FHD laptop, one reason I prefer FlatLaf over other LAFs is because the tabs are a usable size. I understand why on other systems, the size might be a problem. I think perhaps considering a compact UI setting might be way to go here - like toolbar icon sizing but broader - not sure there is a one size fits all solution (pun intended! :smile:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
