mbien commented on code in PR #4390:
URL: https://github.com/apache/netbeans/pull/4390#discussion_r922669826
##########
java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/DefaultPlatformImpl.java:
##########
@@ -84,6 +102,12 @@ static JavaPlatform create(Map<String,String> properties,
List<URL> sources, Lis
return new DefaultPlatformImpl(installFolders, properties,
systemProperties, sources, javadoc);
}
+ private static boolean isValidJDKHome(Path javaHome) {
+ return Files.exists(javaHome.resolve(Path.of("bin", "java")))
+ && Files.exists(javaHome.resolve(Path.of("bin", "javac")));
+// && Files.exists(javaHome.resolve(Path.of("jmods",
"java.base.mod"))); // TODO: uncomment once everything migrated to 11+
Review Comment:
I tested this with the jmods line uncommented, but then I realized that this
is probably used by VSCode too.
So you are saying the `jdk.home` property has no use at this point in the
lifecycle anymore, I should simply change it to `java.home`, do no validation
and therefore also no notifications since it can't ever be wrong at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
