mbien commented on code in PR #4467:
URL: https://github.com/apache/netbeans/pull/4467#discussion_r937744259
##########
java/java.source.base/src/org/netbeans/modules/java/source/transform/ImmutableTreeTranslator.java:
##########
@@ -1429,18 +1502,43 @@ private DefaultCaseLabelTree
rewriteChildren(DefaultCaseLabelTree tree) {
return tree;
}
- private GuardedPatternTree rewriteChildren(GuardedPatternTree tree) {
- PatternTree newPattern = (PatternTree) translate(tree.getPattern());
- ExpressionTree newGuard = (ExpressionTree)
translate(tree.getExpression());
- if (newPattern != tree.getPattern() ||
- newGuard != tree.getExpression()) {
- GuardedPatternTree n = make.GuardedPattern(newPattern, newGuard);
+ private ConstantCaseLabelTree rewriteChildren(ConstantCaseLabelTree tree) {
+ ExpressionTree newExpression =
(ExpressionTree)translate(tree.getConstantExpression());
+ if (newExpression != tree.getConstantExpression()) {
+ ConstantCaseLabelTree n = make.ConstantCaseLabel(newExpression);
model.setType(n, model.getType(tree));
- copyCommentTo(tree,n);
+ copyCommentTo(tree,n);
copyPosTo(tree,n);
- tree = n;
- }
- return tree;
+ tree = n;
+ }
+ return tree;
+ }
+
+ private PatternCaseLabelTree rewriteChildren(PatternCaseLabelTree tree) {
+ ExpressionTree newGuard = (ExpressionTree)translate(tree.getGuard());
+ PatternTree newPattern = (PatternTree)translate(tree.getPattern());
+ if (newGuard != tree.getGuard() || newPattern != tree.getPattern()) {
+ PatternCaseLabelTree n = make.PatternCaseLabel(newPattern,
newGuard);
+ model.setType(n, model.getType(tree));
+ copyCommentTo(tree,n);
+ copyPosTo(tree,n);
+ tree = n;
+ }
+ return tree;
+ }
+
+ private DeconstructionPatternTree
rewriteChildren(DeconstructionPatternTree tree) {
+ ExpressionTree newDeconstructor =
(ExpressionTree)translate(tree.getDeconstructor());
+ List<? extends PatternTree> newNestedPatterns =
translate(tree.getNestedPatterns());
+ VariableTree newVariable = (VariableTree)translate(tree.getVariable());
+ if (newDeconstructor != tree.getDeconstructor() || newVariable !=
tree.getVariable() || !Objects.equals(newNestedPatterns,
tree.getNestedPatterns())) {
+ DeconstructionPatternTree n =
make.DeconstructionPattern(newDeconstructor, newNestedPatterns, newVariable);
+ model.setType(n, model.getType(tree));
+ copyCommentTo(tree,n);
+ copyPosTo(tree,n);
+ tree = n;
+ }
+ return tree;
}
Review Comment:
broken formatting in this section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
