matthiasblaesing commented on PR #4472: URL: https://github.com/apache/netbeans/pull/4472#issuecomment-1209825844
In general I refrain from creating a library if there is no clear advantage. The problem with libraries and NetBeans "we never break API" attitude is, that you set thinks in stone, that you might regret. If the code is copied you pay by maybe doing work twice, but on the other hand you gain bigger freedoms. Not sure where I'd make the tradeoff, but two use sites seems not enough for the introduced dependency. > Also it might be good to try to move the ANTLRv3 stuff to ANTLRv4... Any reason to do so? The dependencies of antlr are more or less trivial and it does not tie into the JVM, so I don't expect problems in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
