[GitHub] [netbeans] ratcashdev commented on a diff in pull request #3995: Support JUnit5 nested test classes

Fri, 02 Sep 2022 00:50:11 -0700 


ratcashdev commented on code in PR #3995:
URL: https://github.com/apache/netbeans/pull/3995#discussion_r961387498


##########
java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java:
##########
@@ -681,6 +681,13 @@ private void generateTest() {
                     }
                 }
 
+                String classname = testcase.getAttributeValue("classname");
+                // keep the embedded class in classnames and add to display 
name
+                int suiteNameLength = suite.getName().length();
+                if (classname.length() > suiteNameLength && 
classname.startsWith(suite.getName())) {
+                    displayName = classname.substring(suiteNameLength) + "." + 
methodName;

Review Comment:
   it should look like this:
   
![image](https://user-images.githubusercontent.com/2928922/188086239-a1c9b783-35db-469f-9918-20211ee81b95.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to