neilcsmith-net commented on PR #4522: URL: https://github.com/apache/netbeans/pull/4522#issuecomment-1235532071
> "Good defaults" are very important, +1! And why I disagree with @matthiasblaesing that this is "philosophical" and doesn't belong in the review. Where else do we review usability?! > using an explicit type for a var instead of an inline hint works only in code where one can write the explicit type. It does not work for reading existing code written by someone else, for example. Firstly there may be a point to having different inline hint defaults in editable vs non-editable code. Not that that covers all bases. Secondly, could this particular hint be moved to the end of the line? Similar to #2365 (and the still open #2785). Direct use of `var` doesn't seem that important compared to assignment by method call? ie. hints to the return type from methods in assignments (where the assignment is `var` _or_ an explicit supertype) might be more useful? And putting it to the right hand side covers some of my concerns about how these influence formatting and written code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
