mbien commented on PR #4678:
URL: https://github.com/apache/netbeans/pull/4678#issuecomment-1276153516
> Looks OK at a glance. I'm curious whether a platform that passes `isValid`
should ever return a `null` spec version?
@neilcsmith-net `isValid` is very basic unfortunately:
```
public boolean isValid() {
return !getInstallFolders().isEmpty();
}
```
Should we move the speck version check into that method?
I am a bit afraid to move more checks there because who knows what else is
affected by that. E.g what if NB thinks the default platform isn't valid on
some exotic setups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
