mbien commented on code in PR #4785:
URL: https://github.com/apache/netbeans/pull/4785#discussion_r995835503
##########
.asf.yaml:
##########
@@ -31,6 +33,23 @@ github:
squash: true
merge: true
rebase: true
+ protected_branches:
+ # no force push to master
+ master:
+# required_pull_request_reviews:
+# required_approving_review_count: 1
+# dismiss_stale_reviews: false
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # list of names of checks that must pass
+# contexts:
+# - Commit Validation on Linux/JDK 11
Review Comment:
the second half of the paperwork job requires the build artifact for
verify-libs-and-licenses, check-sigtests-release and check-sigtests-release. So
we would have to split it to have one part of it before/without the build and
the other as normal secondary, post-build job.
Although I am wondering what happens if B depends on A, A is skipped and B
is set to `always()`. If it still runs we might have our way out without having
to split the job. Something I can test in my sandbox.
As a workaround we could simply avoid `ci:no-build` on PRs from new
contributors so that we have the option to inspect the papers. (I mean
inspection via checkout is always possible, thats how I used to do it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
