mbien commented on code in PR #4792:
URL: https://github.com/apache/netbeans/pull/4792#discussion_r996335226
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/DocumentSwitcherTable.java:
##########
@@ -152,7 +152,21 @@ boolean onMouseEvent( MouseEvent e ) {
TabActionEvent tae = new TabActionEvent( this,
TabbedContainer.COMMAND_CLOSE, tabIndex );
controller.postActionEvent( tae );
return true;
+ }else if(tabIndex == -1){
+ List<TabData> tabs =
controller.getTabModel().getTabs();
+ ProjectProxy project = item.project;
+ ProjectSupport projectSupport =
ProjectSupport.getDefault();
+ for(int i = tabs.size(); i-- > 0;){
+ TabData projectTab = tabs.get(i);
+ if(projectSupport.getProjectForTab(projectTab) ==
(project) || projectSupport.getProjectForTab(projectTab).equals(project)){
Review Comment:
good thinking. How about:
```java
ProjectProxy projectForTab = projectSupport.getProjectForTab(projectTab);
if ((project == null && projectForTab == null) || (projectForTab != null
&& projectForTab.equals(project))) {
```
this would make it explicit that there is a case where both are null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
