eirikbakke commented on code in PR #4792:
URL: https://github.com/apache/netbeans/pull/4792#discussion_r1015760688
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/DocumentSwitcherTable.java:
##########
@@ -132,26 +132,29 @@ boolean onMouseEvent( MouseEvent e ) {
p = SwingUtilities.convertPoint((Component) e.getSource(), p, this);
int selRow = getSelectedRow();
int selCol = getSelectedColumn();
- if( selRow < 0 || selCol < 0 )
+ if ( selRow < 0 || selCol < 0 )
return false;
Rectangle rect = getCellRect( selRow, selCol, false );
- if( rect.contains( p ) ) {
+ if ( rect.contains( p ) ) {
Dimension size = btnClose.getPreferredSize();
int x = rect.x+rect.width-size.width;
int y = rect.y + (rect.height-size.height)/2;
Rectangle btnRect = new Rectangle( x, y, size.width, size.height);
boolean inButton = btnRect.contains( p );
boolean mustRepaint = inCloseButtonRect != inButton;
inCloseButtonRect = inButton;
- if( inButton ) {
- if( e.getID() == MouseEvent.MOUSE_PRESSED ) {
+ if ( inButton ) {
+ if ( e.getID() == MouseEvent.MOUSE_PRESSED ) {
Item item = ( Item ) getModel().getValueAt( selRow, selCol
);
TabData tab = item.getTabData();
+ int tabSize = controller.getTabModel().size();
int tabIndex = controller.getTabModel().indexOf( tab );
if( tabIndex >= 0 ) {
TabActionEvent tae = new TabActionEvent( this,
TabbedContainer.COMMAND_CLOSE, tabIndex );
controller.postActionEvent( tae );
- return true;
+ return tabSize == 1;
Review Comment:
Great, thanks!
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/DocumentSwitcherTable.java:
##########
@@ -174,7 +177,27 @@ public String getToolTipText( MouseEvent event ) {
}
return null;
}
-
+
+ boolean closeSelectedDocumentList() {
+ List<TabData> tabs = controller.getTabModel().getTabs();
+ Item item = ( Item ) getModel().getValueAt( getSelectedRow(),
getSelectedColumn());
+ ProjectProxy project = item.getProject();
+ ProjectSupport projectSupport = ProjectSupport.getDefault();
+ int numOfOtherTabs = 0;
+ for ( int i = tabs.size(); i-- > 0; ) { //reverse iteration to close
tabs from the end so tabIndex does not change
+ TabData projectTab = tabs.get( i );
+ ProjectProxy projectForTab = projectSupport.getProjectForTab(
projectTab );
+ if (( project == null && projectForTab == null ) || (
projectForTab != null && projectForTab.equals( project ))) {
Review Comment:
Makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
