neilcsmith-net commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328040112
> One question: why are you using hard-coded paths instead of rpm macros?
ie: /usr/bin vs %{_bindir}
Because I had a problem with `rpmbuild` resolving `%{_libdir}` to be
`/usr/lib64` and then complaining about missing files. The image and the
`/bin/netbeans` file are currently built to expect `/usr/lib`. This is
mentioned in the to-do at
https://github.com/apache/netbeans-tools/blob/master/nbpackage/src/main/java/org/apache/netbeans/nbpackage/rpm/RpmTask.java#L68
While `%{_bindir}` is probably OK, it made sense to hard-code all the paths
set in the image for now, unless I'm missing something obvious?
Removing the wildcard on `/usr/lib/` also seems to be needed to ensure the
`/usr/lib/apache-netbeans` directory is deleted on uninstall.
I couldn't get either the noarch (without JDK) or x86_64 (with JDK)
packaging to work on my setup. They both work for you before? And with these
changes?
> I also have a suggestion for a future version: signing rpms.
Sounds like it could be a good addition. The macOS packager is the only one
with built in signing, including signing of binaries inside JARs, currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
