jglick commented on code in PR #5099:
URL: https://github.com/apache/netbeans/pull/5099#discussion_r1049996661
##########
java/maven/src/org/netbeans/modules/maven/api/output/OutputUtils.java:
##########
@@ -123,7 +123,7 @@ public static OutputListener matchStackTraceLine(String
line, FileObject fileObj
*/
private static StacktraceAttributes matchStackTraceLine(String line) {
Matcher match = linePattern.matcher(line);
- if (match.matches() && match.groupCount() == 3) {
+ if (match.find() && match.groupCount() == 3) {
Review Comment:
Or maybe more concretely still, in this context, what would examples be of
`line` and `linePattern` that would pass `find` but not `matches`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
