lbruun commented on PR #3: URL: https://github.com/apache/netbeans-native-installers/pull/3#issuecomment-1357975611
Excellent step you are taking. For me it is all about - **Repeatability**. The artifact used by the NetBeans distribution must be build by a pipeline _and_ uploaded to its final destination (from where NetBeans distro picks it up) by a pipeline. - **Traceability**. It must be possible to look at a build artifact and see exactly from where and from which commit it originates. This is typically solved by Git tagging, but if you are including a BUILDINFO file in the distributed artifact then tagging is not necessary per se. You can see in [build-for-native-profiler-lib](https://github.com/apache/netbeans/blame/master/.github/workflows/native-binary-build-lib.profiler.yml) how this might be done. The BUILDINFO has the advantage that it can also convey a repo URL which is increasingly important now that all the native stuff will be in lots of different repos. As for unifying (to some extend) which tool chain is being used, I'm all for it. Other: - Tool chain requirements should be documented in the repo's README. - Branch workflow should be documented in the repo's README, in particular what it requires to create a real release. For example, this may be triggered by a commit to `main` branch. - If this is a new repo, why is the branch called `master` and not `main` ? From what I know, the ASF is quite involved with the Inclusive Naming Initiative, I remember some email to all ASF committers about a year ago? .. so we might as well start out on the right foot. My comments are more in the things-to-remember category. They should not be seen as a blocker to merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
