neilcsmith-net commented on PR #4692: URL: https://github.com/apache/netbeans/pull/4692#issuecomment-1372076605
> we might be able to turn the commit validation tests off on JDK 8. I personally don't think we should put time into it to try to fix them given that NB doesn't technically support running on JDK 8 anymore anyway. But we should discuss this first on the mailing list i believe. @neilcsmith-net right? Yes, a discussion for the mailing list, once we know what (sub)projects still require JDK 8, and for what modules. Let's separate that question out from whether there is a legitimate problem here. As currently set up, any module that requires JDK 8+ needs to specify that in its requirements. I think the (or at least _a_) problem is `j2ee.kit` not requiring JDK 11 and/or specifying the dependency optionally. That's possibly a discussion for the mailing list too. Although does the EE10 support strictly require the IDE modules to be running on JDK 11+ or just the projects? > I don't have a lot of experience with this ignore list but the message basically says how to fix it: > `Some binaries are duplicated (edit nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps as needed)` > @matthiasblaesing can we put those jars simply on the ignore list? Somewhat depends if the duplication is expected / intended?! As for the addition of the NB17 milestone, would be nice to get this fixed up and in inside the next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
