mbien commented on code in PR #5205:
URL: https://github.com/apache/netbeans/pull/5205#discussion_r1063264306
##########
platform/openide.awt/src/org/openide/awt/SplittedPanel.java:
##########
@@ -779,10 +779,10 @@ private void initAccessible() {
getAccessibleContext().setAccessibleName(
nameFormat.format(
new Object[] {
- ((firstComponent == null) || !(firstComponent instanceof
Accessible)) ? null
+ (!(firstComponent instanceof Accessible)) ? null
: firstComponent.getAccessibleContext()
.getAccessibleName(),
- ((secondComponent == null) || !(secondComponent instanceof
Accessible)) ? null
+ (!(secondComponent instanceof Accessible)) ? null
: secondComponent.getAccessibleContext()
.getAccessibleName()
Review Comment:
same here
##########
platform/openide.awt/src/org/openide/awt/SplittedPanel.java:
##########
@@ -779,10 +779,10 @@ private void initAccessible() {
getAccessibleContext().setAccessibleName(
nameFormat.format(
new Object[] {
- ((firstComponent == null) || !(firstComponent instanceof
Accessible)) ? null
+ (!(firstComponent instanceof Accessible)) ? null
: firstComponent.getAccessibleContext()
.getAccessibleName(),
Review Comment:
could you adjust the formatting here a little bit? this could be one line
now.
```java
(!(firstComponent instanceof Accessible)) ? null :
firstComponent.getAccessibleContext().getAccessibleName(),
```
##########
platform/openide.awt/src/org/openide/awt/SplittedPanel.java:
##########
@@ -797,10 +797,10 @@ private void initAccessible() {
getAccessibleContext().setAccessibleDescription(
descriptionFormat.format(
new Object[] {
- ((firstComponent == null) || !(firstComponent instanceof
Accessible)) ? null
+ (!(firstComponent instanceof Accessible)) ? null
: firstComponent.getAccessibleContext()
.getAccessibleDescription(),
Review Comment:
same here
##########
platform/openide.awt/src/org/openide/awt/SplittedPanel.java:
##########
@@ -797,10 +797,10 @@ private void initAccessible() {
getAccessibleContext().setAccessibleDescription(
descriptionFormat.format(
new Object[] {
- ((firstComponent == null) || !(firstComponent instanceof
Accessible)) ? null
+ (!(firstComponent instanceof Accessible)) ? null
: firstComponent.getAccessibleContext()
.getAccessibleDescription(),
- ((secondComponent == null) || !(secondComponent instanceof
Accessible)) ? null
+ (!(secondComponent instanceof Accessible)) ? null
: secondComponent.getAccessibleContext()
.getAccessibleDescription()
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
