BradWalker commented on code in PR #5309: URL: https://github.com/apache/netbeans/pull/5309#discussion_r1073047792
########## enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/CmFieldGenerator.java: ########## @@ -22,11 +22,7 @@ import com.sun.source.tree.ClassTree; import com.sun.source.tree.MethodTree; import java.io.IOException; -import java.util.Arrays; -import java.util.Collections; -import java.util.HashSet; -import java.util.Map; -import java.util.Set; +import java.util.*; Review Comment: This is a problem. It breaks the jdeps(1) dependency mapping. In addition, it kills the modularity of the project. For this reason, I have to give it a -1. Can you please fix changes like this and resubmit. ########## enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/SelectMethodGenerator.java: ########## @@ -20,10 +20,7 @@ package org.netbeans.modules.j2ee.ejbcore.action; import java.io.IOException; -import java.util.ArrayList; -import java.util.HashSet; -import java.util.List; -import java.util.Set; +import java.util.*; Review Comment: This is a problem. It breaks the jdeps(1) dependency mapping. In addition, it kills the modularity of the project. For this reason, I have to give it a -1. Can you please fix changes like this and resubmit. ########## enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/actions/JaxWsCodeGenerator.java: ########## @@ -30,12 +30,7 @@ import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.text.MessageFormat; -import java.util.Arrays; -import java.util.Collections; -import java.util.HashSet; -import java.util.List; -import java.util.Set; -import java.util.StringTokenizer; +import java.util.*; Review Comment: This is a problem. It breaks the jdeps(1) dependency mapping. In addition, it kills the modularity of the project. For this reason, I have to give it a -1. Can you please fix changes like this and resubmit. ########## enterprise/web.el/src/org/netbeans/modules/web/el/ELTypeUtilities.java: ########## @@ -20,17 +20,7 @@ import com.sun.el.parser.*; import java.net.URL; -import java.util.ArrayDeque; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.Deque; -import java.util.HashMap; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Set; +import java.util.*; Review Comment: This is a problem. It breaks the jdeps(1) dependency mapping. In addition, it kills the modularity of the project. For this reason, I have to give it a -1. Can you please fix changes like this and resubmit. I'm going to stop here, but there are several others that would receive the same comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
