sdedic opened a new pull request, #5361: URL: https://github.com/apache/netbeans/pull/5361
"Refresh" action is available on OCI nodes including the leaves; but a leaf has no `factory` set, so refresh is likely to NPE. The `Connect` action implementation was written so that it blocked the UI thread with a modal dialog and/or sync with the background DB connection. It should have been rewritten probably more thoroughly, but at the least I've changed the action to `asynchronous=true` - I needed to restructure it to implement `ActionListener` + `ContextAwareAction` so that it properly reports DB connection changes through action's enable once instantiated. Asynchronous=true does not work well for `NodeActions` (default constructor must not be present). Asynchronous processing is desirable in the headless mode, when the blocked "ui" thread is actually usually the message-processing one, which may block the client from all messages to/from the NBLS server. As a result even Swing-bound parts now run asynchronously, so the UI parts were wrapped into `invokeLater`/`invokeAndWait`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
