sdedic commented on code in PR #5363:
URL: https://github.com/apache/netbeans/pull/5363#discussion_r1088655051
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DownloadWalletAction.java:
##########
@@ -105,7 +110,22 @@ public void actionPerformed(ActionEvent ev) {
if (p.getDbUser() != null && p.getDbPassword() != null) {
JDBCDriver[] drivers =
JDBCDriverManager.getDefault().getDrivers("oracle.jdbc.OracleDriver"); //NOI18N
+ JDBCDriver jarsPresent = null;
+
if (drivers.length > 0) {
+
+ // prefer a driver that actually defines some JARs.
+ for (JDBCDriver d : drivers) {
+ if (isAvailable(d)) {
+ jarsPresent = d;
+ break;
+ }
+ }
+ if (jarsPresent == null) {
+ jarsPresent = drivers[0];
+ // PENDING: should be shown to the user ?
+ LOG.log(Level.WARNING, "Unable to find driver JARs
for wallet {0}, using fallback driver: {1}", new Object[] { walletPath,
jarsPresent.getName() });
+ }
Review Comment:
Addressed in 7ce696e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
