akronenw opened a new pull request, #5453: URL: https://github.com/apache/netbeans/pull/5453
This PR fixes an issue with Wildfly servers. I noticed that, after successful starting a Wildfly (JBoss) server, I was not able to restart or stop the instance in the `Services->Server->rightclick on server`-view. The respective menu items were grayed out, instead it was possible to start the server (although it was already running). I investigated that and found out, that NetBeans did not take into account the port offset that can be specified in the `standalone.xml` server config file. Hence, in case a port offset is specified, NetBeans always checks against the wrong port and does not recognize a correctly started server. What I did: * I bundled hardcoded port numbers in a single place. * I added a handler for port bindings from the config file, that also saves the port offset. * When the server is set up, the config file is parsed and the offset added to the ports specified in the NetBeans server wizard. * I refactored some code, mostly related to the files I touched anyway, hopefully not too much. I tested this successfully on my machine, but I am not sure whether there are any side effects that I did not fathom. Two things that I'd like to ask: * Should NetBeans show a hint in the wizard when a port offset is detected, so the user knows the ports he enters are not the ones under which the running instance is reachable? * While testing I got a bunch of warnings: `Parameter file was not normalized...` from `FileUtil#getFileObject`. After a clean build those warnings disappeared, they did not seem to do any harm. Why did that happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
