mbien commented on code in PR #5332:
URL: https://github.com/apache/netbeans/pull/5332#discussion_r1103617555
##########
webcommon/lib.v8debug/src/org/netbeans/lib/v8debug/client/cmdline/V8Debug.java:
##########
@@ -1020,17 +1020,10 @@ private String printStr(V8Value value) {
if (o.getProperties() != null) {
Map<String, V8Object.Property> properties =
o.getProperties();
String newLine = System.getProperty("line.separator");
- for (String propName : properties.keySet()) {
- sb.append(newLine);
- sb.append(" ");
- sb.append(propName);
- sb.append(" = ");
- V8Object.Property property = properties.get(propName);
- sb.append('(');
- sb.append(property.getType());
- sb.append(") ref: ");
- sb.append(property.getReference());
- }
+
+ properties.forEach((propName, v8Prop) -> {
+ sb.append(newLine + " " + propName + " = (" +
v8Prop.getType() + ") ref: " + v8Prop.getReference());
+ });
Review Comment:
this PR is not about `append`. Please keep the code as is and restrict
changes to collections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
