lbownik commented on code in PR #5530:
URL: https://github.com/apache/netbeans/pull/5530#discussion_r1111317984
##########
ide/httpserver/src/org/netbeans/modules/httpserver/HttpServerSettings.java:
##########
@@ -428,54 +382,6 @@ Set<String> getGrantedAddressesSet() {
return addr;
}
- Properties getMappedServlets() {
- return mappedServlets;
- }
-
- /** Converts string into string that is usable in URL.
- * This mangling changes some characters
- */
- static String mangle (String name) {
- StringBuffer sb = new StringBuffer ();
- for (int i = 0; i < name.length (); i++) {
- if (Character.isLetterOrDigit (name.charAt (i)) ||
- name.charAt (i) == '.') {
- sb.append (name.charAt (i));
- }
- else {
- String code = Integer.toHexString ((int)name.charAt
(i)).toUpperCase ();
- if (code.length ()<2)
- code = (code.length () == 0)? "00": "0"+code; // NOI18N
- sb.append ("%"). // NOI18N
- append ((code.length () == 2)? code: code.substring
(code.length ()-2));
- }
- }
- return sb.toString ();
- }
-
- /** Unconverts string from URL into old string.
- * This mangling decodes '%xy'
- */
- static String demangle (String name) {
- StringBuffer sb = new StringBuffer ();
Review Comment:
since this file is already touched why not changing this to StringBuilder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
