mbien commented on code in PR #5482:
URL: https://github.com/apache/netbeans/pull/5482#discussion_r1111334564
##########
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java:
##########
@@ -149,6 +153,9 @@ public class MavenCommandLineExecutor extends
AbstractMavenExecutor {
private static final RequestProcessor UPDATE_INDEX_RP = new
RequestProcessor(RunUtils.class.getName(), 5);
private static final String ICON_MAVEN_PROJECT =
"org/netbeans/modules/maven/resources/Maven2Icon.gif"; // NOI18N
+
+ private final Function<String, Boolean> mavenCommandMultiThreadAnalyzer =
isMavenDaemon() ? MavenCommandParametersAnalyzer::isMultiThreaded :
MavenDaemonCommandParametersAnalyzer::isMultiThreaded ;
+
Review Comment:
sure, by inline I mean the following:
remove the function declaration (L156-L158) and put it into
`isMultiThreaded()` like:
```java
private boolean isMultiThreaded(BeanRunConfig clonedConfig) {
// .... more code ...
return isMavenDaemon() ?
MavenCommandParametersAnalyzer.isMultiThreaded(mavenCommandParameters)
:
MavenDaemonCommandParametersAnalyzer.isMultiThreaded(mavenCommandParameters);
}
```
NB can inline things by pressing `alt+shift+N`. But that didn't work
properly in this particular case (sorry for the confusion).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
