KacerCZ commented on code in PR #5534:
URL: https://github.com/apache/netbeans/pull/5534#discussion_r1112262521
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -430,18 +430,15 @@ private void checkDuplicateType(List<Expression> types) {
}
if (checkedTypes.contains(name)) {
createDuplicateTypeError(type, typeName);
- return;
Review Comment:
Right, original code with early exit finishes faster.
If there is no error then all types will be checked anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
