matthiasblaesing commented on code in PR #5568:
URL: https://github.com/apache/netbeans/pull/5568#discussion_r1119133753
##########
nbbuild/antsrc/org/netbeans/nbbuild/CheckModuleConfigs.java:
##########
@@ -80,8 +80,8 @@ public void setNbroot(File f) {
}
allClusters.put(m.group(1), splitToList((String)
clusterDef.getValue(), clusterDef.getKey()));
}
- allClusters.get("experimental").removeAll(allClusters.get("betauc"));
// intentionally a superset
- allClusters.get("betauc").removeAll(allClusters.get("stableuc")); //
ditto
+//
allClusters.get("experimental").removeAll(allClusters.get("betauc")); //
intentionally a superset
+// allClusters.get("betauc").removeAll(allClusters.get("stableuc")); //
ditto
Review Comment:
I would remove this completely. The whole setup around `experimental` and
`betauc` looks like a hack and it is IMHO better to remove it and if needed in
the future we might have better ideas.
##########
nbbuild/build.xml:
##########
@@ -19,7 +19,7 @@
under the License.
-->
-<project name="nbbuild" default="build-nozip" basedir="." xmlns:if="ant:if"
xmlns:unless="ant:unless">
+<project name="nbbuild" default="build" basedir="." xmlns:if="ant:if"
xmlns:unless="ant:unless">
Review Comment:
Is this an intentional change? In nearly 100% of my builds I'm not
interested in the ZIP and I'm not interesting in having ZIPs messing up my
system, so I'd like to retain the normal build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
