neilcsmith-net commented on PR #18: URL: https://github.com/apache/netbeans-nbpackage/pull/18#issuecomment-1466747941
Thanks, generally seems to do the right thing. Have updated the comments and switched to `maven-resources-plugin` for copying into apidocs. https://github.com/apache/netbeans-nbpackage/commit/dbfe8ff7f8ca2d59edf50579a87c19bee6e48f82 Do you think we need the license and notice in the javadoc jar? It's a shame that we lose the dependencies file from META-INF, although the information in that isn't great anyway. Tried not skipping the remote resources plugin and overwriting the notice and license, but I couldn't make it work everywhere. If you're happy with changes, should I squash my commit with yours and push here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
